search

ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
255 stars 106 forks source link

Using [self: instance] annotation in sinatra gem #569

Closed euglena1215 closed 4 months ago

euglena1215 commented 4 months ago

When a method is called within a block of HTTP methods such as get, post in the sinatra gem, it should have been treated as calling an instance method, but was evaluated as a singleton method. By adding [self: instance] to the method block of each HTTP method, processing within the block is now treated as processing in the instance.

github-actions[bot] commented 4 months ago

@euglena1215 Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

sinatra-contrib

You changed RBS files for an existing gem. You can merge this PR yourself because you are a reviewer of this gem. Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.

sinatra

You changed RBS files for an existing gem. You can merge this PR yourself because you are a reviewer of this gem. Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.

euglena1215 commented 4 months ago

/merge