search

ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
255 stars 106 forks source link

Manually add the return types of a couple of ActiveSupport methods #576

Closed hibariya closed 3 months ago

hibariya commented 3 months ago

I've changed the return types of String#{camelize,underscore,dasherize}. Since I'm new to writing RBS and it's the first patch to the RBS files, I'd appreciate it if someone could take a look. /cc @pocke

github-actions[bot] commented 3 months ago

@hibariya Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

activesupport

You changed RBS files for an existing gem. This gem does not have reviewers. So you can merge this PR immediately if the CI passes. We recommend you add yourself to the reviewers for this gem.

github-actions[bot] commented 3 months ago

Thanks for your review, @pocke!

@hibariya, @pocke This PR is ready to be merged. Just comment /merge to merge this PR.

hibariya commented 3 months ago

/merge