search

ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
246 stars 101 forks source link

activerecord: if/unless proc params can take an instance as an argument #578

Closed tk0miya closed 3 weeks ago

tk0miya commented 3 weeks ago

Proc objects for if/unless params to the validation and hook methods can take an instance of the AR model as an argument.

github-actions[bot] commented 3 weeks ago

@tk0miya Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

activerecord

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@hibariya, please review this pull request. If this change is acceptable, please make a review comment including APPROVE from here. Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.

github-actions[bot] commented 3 weeks ago

Thanks for your review, @hibariya!

@tk0miya, @hibariya This PR is ready to be merged. Just comment /merge to merge this PR.

hibariya commented 3 weeks ago

/merge