search

ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
246 stars 101 forks source link

Export from steep #579

Open ksss opened 3 weeks ago

ksss commented 3 weeks ago

Steep has definitions for the parser, https://github.com/soutaro/steep/tree/55c58d0f8aa1fc65a8add95a5fde43f6b4375164/sig/shims but they conflict with those in gem_rbs_collection, so only one can be used.

I believe the best approach for the community is to support and develop the ones in gem_rbs_collection.

Here are the steps I propose:

  1. Stop distributing the sig directory from Steep.
  2. Merge the parser definitions from Steep into gem_rbs_collection.

@soutaro @pocke How about you all?

github-actions[bot] commented 3 weeks ago

@ksss Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

parser

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@pocke, please review this pull request. If this change is acceptable, please make a review comment including APPROVE from here. Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.

pocke commented 3 weeks ago

BTW I checked the contributors of the RBS files for the parser gems. There is no contributor other than Soutaro-san. So we do not need to be concerned about the license (if Soutaro-san approves it of course). https://github.com/soutaro/steep/commits/master/sig/shims/parser

soutaro commented 2 weeks ago

I didn't have an idea to export the interfaces. They are opinionated, unfinished, and not used in fact recently... Totally 👍 for other parts.