ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
255 stars 106 forks source link

Add me to reviewer for couple of rails dependent gems #584

Closed ydah closed 3 months ago

ydah commented 3 months ago

https://github.com/ruby/gem_rbs_collection/issues/558#issuecomment-2147048415

github-actions[bot] commented 3 months ago

@ydah Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.


actionmailer

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@ksss, please review this pull request. If this change is acceptable, please make a review comment including APPROVE from here. Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.


actionview

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@ksss, please review this pull request. If this change is acceptable, please make a review comment including APPROVE from here. Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.


activesupport

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@hibariya, @ksss, please review this pull request. If this change is acceptable, please make a review comment including APPROVE from here. Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.

hibariya commented 3 months ago

/merge

github-actions[bot] commented 3 months ago

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers. See the Actions tab for detail.

ksss commented 3 months ago

APPROVE 👍

ksss commented 3 months ago

/merge

github-actions[bot] commented 3 months ago

/merge command failed.

This PR is not approved yet by the reviewers. Please get approval from the reviewers. See the Actions tab for detail.

ksss commented 3 months ago

/merge