ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
246 stars 101 forks source link

ActiveSupport String inflections #593

Closed hibariya closed 2 weeks ago

github-actions[bot] commented 2 weeks ago

@hibariya Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.


activesupport

You changed RBS files for an existing gem. You can merge this PR yourself because you are a reviewer of this gem. Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.

ksss commented 2 weeks ago
$ bundle exec rbs diff --detail --format diff --type-name String --before gems/activesupport/6.0 --after 593
- [::String public] def safe_constantize: () -> untyped
+ [::String public] def safe_constantize: () -> untyped?

- [::String public] def titleize: (?keep_id_suffix: bool keep_id_suffix) -> untyped
+ [::String public] def titleize: (?keep_id_suffix: ::boolish) -> ::String

- [::String public] def demodulize: () -> untyped
+ [::String public] def demodulize: () -> ::String

- [::String public] def deconstantize: () -> untyped
+ [::String public] def deconstantize: () -> ::String

- [::String public] def parameterize: (?locale: untyped? locale, ?preserve_case: bool preserve_case, ?separator: ::String separator) -> untyped
+ [::String public] def parameterize: (?separator: ::String, ?preserve_case: ::boolish, ?locale: ::Symbol) -> ::String

- [::String public] def tableize: () -> untyped
+ [::String public] def tableize: () -> ::String

- [::String public] def classify: () -> untyped
+ [::String public] def classify: () -> ::String

- [::String public] def humanize: (?keep_id_suffix: bool keep_id_suffix, ?capitalize: bool capitalize) -> untyped
+ [::String public] def humanize: (?capitalize: ::boolish, ?keep_id_suffix: ::boolish) -> ::String

- [::String public] def upcase_first: () -> untyped
+ [::String public] def upcase_first: () -> ::String

- [::String public] def foreign_key: (?bool separate_class_name_and_id_with_underscore) -> untyped
+ [::String public] def foreign_key: (?::boolish separate_class_name_and_id_with_underscore) -> ::String
ksss commented 2 weeks ago

https://github.com/rails/rails/blob/v6.0.6.1/activesupport/lib/active_support/core_ext/string/inflections.rb https://github.com/rails/rails/blob/v7.1.3.4/activesupport/lib/active_support/core_ext/string/inflections.rb