search

ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
255 stars 106 forks source link

remove: ActiveModel::Serialization#send and ActiveModel::Validations#send #595

Closed rhiroe closed 3 months ago

rhiroe commented 3 months ago

Passing a Symbol argument to these methods will result in an error.

Cannot pass a value of type `::Symbol` as an argument of type `::String`
  ::Symbol <: ::String
    ::Object <: ::String
      ::BasicObject <: ::String(Ruby::ArgumentTypeMismatch)

Also, these methods do not exist.

https://github.com/ruby/gem_rbs_collection/commit/2e17636b572835f4b114dbb7c8942f007e71d69a It appears to have been added by this commit, but appears to work fine without it now.

github-actions[bot] commented 3 months ago

@rhiroe Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

activemodel

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@hibariya, @ksss, please review this pull request. If this change is acceptable, please make a review comment including APPROVE from here. Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.

rhiroe commented 3 months ago

/merge