ruby / gem_rbs_collection

A collection of RBS for gems.
MIT License
246 stars 101 forks source link

add Faraday::TooManyRequestsError #610

Closed tasuku-lab280 closed 1 week ago

tasuku-lab280 commented 1 week ago

Added Faraday::TooManyRequestsError type added in faraday version 2.7.12 https://github.com/lostisland/faraday/releases/tag/v2.7.12

Also, the faraday version 2.7 directory was missing and has been added.

github-actions[bot] commented 1 week ago

@tasuku-lab280 Thanks for your contribution!

Please follow the instructions below for each change. See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.


faraday

You changed RBS files for an existing gem. You need to get approval from the reviewers of this gem.

@yykamei, please review this pull request. If this change is acceptable, please make a review comment including APPROVE from here. Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR. Just comment /merge to merge this PR.

tasuku-lab280 commented 1 week ago

@yykamei

Thank you so much for your review 👍 It is very clear!

I too felt that copying the 2.5 type file was redundant and was wondering whether to use a symbolic link or a symbolic link.

it's better to use symbolic links for faraday v2.7 because faraday tries to stick to semantic versioning, which means there are no breaking changes among minor versions. We don't have to consider the cons of using symbolic links for faraday.

This opinion convinced me too, so I think I will change to symbolic links. I have made the change in the following commit and would appreciate a re-review!

https://github.com/ruby/gem_rbs_collection/pull/610/commits/b636b1d21720354ab9f7ac322318f2b38b513197

github-actions[bot] commented 1 week ago

Thanks for your review, @yykamei!

@tasuku-lab280, @yykamei This PR is ready to be merged. Just comment /merge to merge this PR.

yykamei commented 1 week ago

/merge