[2.7.x] Raise JSON::GeneratorError instead of Encoding::UndefinedConversionError

ruby / json

JSON implementation for Ruby

https://ruby.github.io/json

Other

705 stars 332 forks source link

[2.7.x] Raise JSON::GeneratorError instead of Encoding::UndefinedConversionError #684

Closed byroot closed 3 weeks ago

byroot commented 3 weeks ago

Followup: https://github.com/ruby/json/pull/633

That's what was raised historically. You could argue that this new exception is more precise, but I've encountered some real production code that expected the old behavior and that was broken by this change.