search

ruby / net-http

Net::HTTP provides a rich library which can be used to build HTTP user-agents.
Other
101 stars 66 forks source link

Refactor Net::HTTP#connect #172

Open stanhu opened 10 months ago

stanhu commented 10 months ago

The method was getting large, and in preparation for #141, I thought it would be easier to break up the method into several other methods.

stanhu commented 10 months ago

https://github.com/ruby/net-http/pull/147/files seems to have a similar refactoring.

stanhu commented 10 months ago

@nurse What do you think about this change?

stanhu commented 6 months ago

@nurse Could you review this?

xlgmokha commented 6 months ago

@hsbt, @nurse do you have time to review this change? This is related to a DNS rebinding issue that we are experiencing on gitlab.com that we are working to resolve. :pray: