search

ruby / net-pop

This library provides functionality for retrieving email via POP3, the Post Office Protocol version 3. For details of POP3
BSD 2-Clause "Simplified" License
21 stars 14 forks source link

Remove needless dependencies #10

Closed eregon closed 2 years ago

eregon commented 2 years ago

These are default gems, so there is no need to explicitly depend on them, and depending on them is actually harmful: https://bugs.ruby-lang.org/issues/18567.

hsbt commented 2 years ago

same as https://github.com/ruby/net-imap/pull/56#issuecomment-1046671082

hsbt commented 2 years ago

I will revert this change when we remove digest or/and timeout from the Ruby stdlibs.

eregon commented 2 years ago

I will revert this change when we remove digest or/and timeout from the Ruby stdlibs.

Is there any plan to do so? That sounds extremely disruptive and never worth it. digest/timeout are used by so many Ruby programs, and they all assume it's part of stdlib.

hsbt commented 2 years ago

digest/timeout are used by so many Ruby programs, and they all assume it's part of stdlib.

Yes, Because I added them to dependencies. But You refuse it. I have no idea to care it.

eregon commented 2 years ago

Right, but thousands of Ruby devs would need to add the dependency, not just in a few default gems. Anyway, I was just curious if there was already a discussion on Redmine (or a plan documented somewhere) to remove digest/timeout from stdlib and what is the rationale. I suspect the gain/cost is very low.