search

ruby / pathname

Pathname represents the name of a file or directory on the filesystem, but not the file itself.
BSD 2-Clause "Simplified" License
26 stars 16 forks source link

Officially drop support for ruby 2.6 or older #13

Closed deivid-rodriguez closed 2 years ago

deivid-rodriguez commented 2 years ago

The gem doesn't even install on old rubies, but since the gemspec claims it's supported, gem install pathname will try to install it and print an error.

This commit doesn't fix the above issue. The only way to fix it would be to restore support and release a new version that actually supports old rubies. However, such a change has been proposed and ignored for a long time. Also I noticed that deprecating taint/untaint was done without considering old rubies, so I think it's clear that maintainers don't want to support ruby 2.6.

So this issue proposes to leave that broken but at least bring the gemspec manifest and the CI matrix in sync to hopefully avoid this issue from happening again in the future.

deivid-rodriguez commented 2 years ago

CI should be fixed once I finish https://github.com/rubygems/rubygems/pull/4992 and release it.

deivid-rodriguez commented 2 years ago

I released a new version of bundler that I think should fix the previous CI issue. So hopefully CI is now green.

deivid-rodriguez commented 2 years ago

Oh nevermind. In this case, pathname is actually included in the Gemfile, so my fix doesn't cover it. This needs to wait for rubygems/rubygems#4992 to get green.

headius commented 2 years ago

Fine with JRuby since we never supported the C extension in this gem. JRuby will need to be added in a separate PR for our Ruby 3.0-compatible release (JRuby 9.4).

hsbt commented 2 years ago

I will look this after releasing Ruby 3.1