Bump Chicory to 1.0.0-M1

ruby / prism

Prism Ruby parser

https://ruby.github.io/prism/

MIT License

845 stars 142 forks source link

Bump Chicory to 1.0.0-M1 #3210

Closed andreaTP closed 2 weeks ago

andreaTP commented 2 weeks ago

:wave: we just released a first Milestone for Chicory, since it's breaking in many ways, I wanted to check that everything remains aligned.

Notes:

we now have a wasi implementation, so, some more code-paths should be usable (for filesystem operation we suggest to use Jimfs though)
we have a new AOT compiler, I would be happy to set up here, basically we can ship a "ready to run" Jar package for Prism, wdyt? (example: wabt)

kddnewton commented 2 weeks ago

Yeah that sounds great! Do you mean add it as an artifact after the build kind of thing? @enebo would you be able to use that?

andreaTP commented 2 weeks ago

I think @enebo will be able to use it easily, I would require some help in setting up the automated release CI,. If that's good for you @kddnewton I'll move forward in the next few days. 😊

BTW, a wonderful experience contributing to this repo! Great job!

kddnewton commented 2 weeks ago

Yeah that's fine. I think just uploading it as an artifact to the build to start would be good. That's what we have for JS and it works fine for now https://github.com/ruby/prism/blob/efd3362a91f9fef296e42e931ef637e60cea18d1/.github/workflows/javascript-bindings.yml#L37-L40

andreaTP commented 2 weeks ago

Thanks for the feedback, @kddnewton , two comments here:

I was aiming to publish a full-fledged Jar to Maven Central as we are already uploading the wasm file to artifacts
I need more time to finalize this proposal as we are hitting some Java bytecode limitations (we are already working on fixing the issue)

All in all, the current setup is fine for now, I'll come up with something when we are ready :slightly_smiling_face:

kddnewton commented 2 weeks ago

Sounds great!