search

ruby / rbs

Type Signature for Ruby
Other
1.96k stars 216 forks source link

Please register rbs in GitHub linguist project for syntax highlight #682

Open st0012 opened 3 years ago

st0012 commented 3 years ago

Currently, there is still no syntax highlight for .rbs files on GitHub (neither files nor markdown snippets). This makes it hard to read rbs code on GitHub and thus makes adoption harder.

To solve this problem, rbs needs to be registered to GitHub's linguist project. The steps are detailed here.

soutaro commented 3 years ago

Hi @st0012! Yes, I know the situation and I want GitHub to support RBS files!

There are two things we have to do according to the steps:

  1. We need > 200 unique repos with .rbs files
  2. We need to define the grammer

Does anyone help me to count the # of repos with .rbs files?

st0012 commented 3 years ago

@soutaro I don't think the 200 unique repos is a hard limit. I think its purpose is to make sure the language is credible. Given that rbs is supported by the Ruby organization and is actively developed, there's no reason to question the credibility.

Also, based on GH there is 139 public repos that depend on this project https://github.com/ruby/rbs/network/dependents.

Regarding the grammar, I thought it's already defined? For example: https://github.com/soutaro/vscode-rbs-syntax/blob/master/syntaxes/rbs.tmLanguage.json

soutaro commented 3 years ago

based on GH there is 139 public repos

Good point. I agree that the syntax would be worth being supported.

I thought it's already defined?

Anyway, I need to review if the grammar is good enough...