search

ruby / resolv

A thread-aware DNS resolver library written in Ruby
Other
36 stars 28 forks source link

Implement dohpath SvcParam #33

Closed hanazuki closed 7 months ago

hanazuki commented 1 year ago

Depends on #32

This patch implements "dohpath" SvcParam proposed in draft-ietf-add-svcb-dns-08. This parameter specifies a URI template for the :path used in DNS-over-HTTPS requests.

"dohpath" is employed by DDR, also a to-be-published Proposed Standard that specifies how to upgrade DNS transport to a more secure one, i.d., DNS-over-TLS or DNS-over-HTTPS. DDR is deployed in the public DNS resolvers including Cloudflare DNS, Google Public DNS, and Quad9.

sorah commented 8 months ago

The draft has been published as https://datatracker.ietf.org/doc/rfc9461/

hsbt commented 8 months ago

@sorah Could you handle this and https://github.com/ruby/resolv/pull/32?

sorah commented 8 months ago

🙆🏻‍♀️

hanazuki commented 8 months ago

RFC 9461 has no difference in the format of "dohpath" from the draft that the patch is originally based on (updated the patch).

hanazuki commented 8 months ago

The entire library seems to prefer the style that uses self.new and explicit return in multiple-sentence methods, which I wanted to preserve as much as possible to respect the original author. (I for myself have no preference for either style.)

sorah commented 8 months ago

which I wanted to preserve as much as possible to respect the original author

This.