ruby / resolv

A thread-aware DNS resolver library written in Ruby
Other
36 stars 28 forks source link

Fix TCP fallback with multiple nameservers [Bug #8285] #50

Open opti opened 2 months ago

opti commented 2 months ago

Originally reported here https://bugs.ruby-lang.org/issues/8285, but the patch has never been finalized.

We stumbled on the same issue under the following conditions:

Expected result:

Resolv::DNS successfully falls back to the next nameserver, using TCP request.

Actual result:

Resolv::DNS::Requester::RequestError: host/port don't match is raised.

This pull request:

opti commented 2 months ago

@sorah, @nobu any chance this can be reviewed?

opti commented 1 month ago

@hanazuki These are valid points. Thank you for the detailed explanation. I've added your commit to this pull request. Thanks for looking into it.

opti commented 1 week ago

@hanazuki any chance this fix can be merged?

hanazuki commented 1 week ago

+1 to merge. I'm not the maintainer and cannot merge or approve PRs.

What do you think, @sorah @nobu?