search

ruby / rexml

REXML is an XML toolkit for Ruby
BSD 2-Clause "Simplified" License
137 stars 63 forks source link

Fix method scope in test in order to invoke the tests properly and fix exception message #182

Closed Watson1978 closed 2 months ago

Watson1978 commented 2 months ago

This PR includes following two fixes.

  1. The test_empty and test_linear_performance_gt were defined as private method. Seems that test-unit runner does not invoke private methods even if the methods have test_ prefix.
  2. When parse malformed entity declaration, the exception might have the message about NoMethodError. The proper exception message will be contained by this fix.
kou commented 2 months ago

Could you update the description that this PR also includes NoMethodError fix before we merge this?

Watson1978 commented 2 months ago

Could you update the description that this PR also includes NoMethodError fix before we merge this?

@kou OK, I updated the description. Thanks.

kou commented 2 months ago

Thanks.