search

ruby / rss

RSS reading and writing
BSD 2-Clause "Simplified" License
185 stars 36 forks source link

Add itunes_image to Items::Item #11

Closed ianrandmckenzie closed 4 years ago

ianrandmckenzie commented 4 years ago

References https://github.com/ruby/rss/issues/8

ianrandmckenzie commented 4 years ago

Sorry about this taking 3 months. I got severely sidetracked by a bunch of different projects. Not sure why all checks failed. I have no experience with Travis, so instructions on how to resolve would be appreciated :)

kou commented 4 years ago

The failure is caused by REXML. I've released a new version of REXML and restarted the failed job. Now CI is green.

I'll review this.

ianrandmckenzie commented 4 years ago

Sounds good! I'm ready to fix any mistakes once you've reviewed.

kou commented 4 years ago

Could you add tests? Or should I take over it?

ianrandmckenzie commented 4 years ago

I'm happy to add tests. I just realized the reason I had put off submitting a PR for so long was that I hadn't. Then, by the time I submitted the PR, I evidently forgot that step. I will add tests and loop back with you.

kou commented 4 years ago

Thanks! If you have any trouble, feel free to ask me here.

ianrandmckenzie commented 4 years ago

I think these tests passed? I ran the test suite before adding my own tests and 312 passed. I added my tests and ran the suite again and it still said 312 passed. The number didn't change. I assume because everything passed, I'm good. But, I expected the number 312 to go up by a little bit. It did not. Happy to make fixes if anything needs to be changed.

edit: I just deleted my implementation from the code and ran my tests again and got 3 errors. Errors are good! I think that means I got it right 😁

ianrandmckenzie commented 4 years ago

@kou I am having a "staycation" this week and have lots of time to contribute to open source. This week would be a good time to let me know if I need to make any fixes. Thanks!

kou commented 4 years ago

Sorry for my late response... I hope that I can review this in this week...

ianrandmckenzie commented 4 years ago

Thank you, @kou! This is the first time my contribution to open source was merged, I'm so happy it was to the Ruby project. Rails is my bread and butter, I'm so happy I could do my part in a small way.

kou commented 4 years ago

Great! We're waiting for your next contribution! :-)