search

ruby / rss

RSS reading and writing
BSD 2-Clause "Simplified" License
185 stars 36 forks source link

style: consistently use double quotes #36

Closed gildesmarais closed 2 years ago

gildesmarais commented 3 years ago

I had a look at the gem's code (due to a Ractor related issue) and noticed the use of quotes was differing throughout. There were even lines with mixed double and single quotes when no String interpolation was done. As 3dea1ef shows, double quotes seem to be desired for this project.

This PR changes all quotes to be double quotes ".

It uses Rubocop on the CI to ensure that all future code will use double quotes, too.

There's a rubocop_todo.yml containing its other findings and gives some more insights into this 17 year old codebase that lived through many Ruby versions. Due to the age, the code sometimes doesn't sound idiomatic IMHO and I think Rubocop will be a good tool to keep up a standard.

I'm open to a discussion regarding this change and I'm fine when this project decides against merging this PR.

kou commented 3 years ago

I'm negative to use RuboCop. It's too offensive for us.

For example, this PR includes changes that are not for quote style change.