ruby / set

This library provides the Set class, which deals with a collection of unordered values with no duplicates.
BSD 2-Clause "Simplified" License
23 stars 13 forks source link

New release? #27

Closed deivid-rodriguez closed 2 years ago

deivid-rodriguez commented 2 years ago

Hi!

I understand this is super RubyGems/Bundler specific, but I'm getting a spec failure when running Bundler specs against Ruby core, which reads like this:

  1) bundler/inline#gemfile when requiring fileutils after does not show redefinition warnings
     Failure/Error: expect(err).to eq("The Gemfile specifies no dependencies")

       Commands:
       $ /Users/deivid/.asdf/installs/ruby/3.2.0-dev/bin/ruby -r/Users/deivid/Code/rubygems/rubygems/bundler/spec/support/hax.rb -w -e require\ \'rubygems/dependency_installer\'\;\ puts\ \$LOADED_FEATURES.grep\(/fileutils/\)
       # $? => 0

       $ /Users/deivid/.asdf/installs/ruby/3.2.0-dev/bin/ruby -r/Users/deivid/Code/rubygems/rubygems/bundler/spec/support/hax.rb -w -e gem\ \'fileutils\',\ \'\<\ 999999\'\;\ require\ \'fileutils\'\;\ puts\ FileUtils::VERSION
       1.6.0
       # $? => 0

       $ gem install --no-document fileutils --version 1.4.1
       Successfully installed fileutils-1.4.1
       1 gem installed
       # $? => 0

       $ gem install --no-document pathname --version 0.2.0
       Building native extensions. This could take a while...
       Successfully installed pathname-0.2.0
       1 gem installed
       # $? => 0

       $ gem install --no-document timeout uri
       Successfully installed timeout-0.3.0
       Successfully installed uri-0.11.0
       2 gems installed
       # $? => 0

       $ gem install --no-document set
       Successfully installed set-1.0.2
       1 gem installed
       # $? => 0

       $ /Users/deivid/.asdf/installs/ruby/3.2.0-dev/bin/ruby -r/Users/deivid/Code/rubygems/rubygems/bundler/spec/support/hax.rb -w -e require\ \'bundler/inline\''
       ''
       '\ \ \ \ \ \ require\ \"bundler/inline\"'
       ''
       '\ \ \ \ \ \ gemfile\(true\)\ do'
       '\ \ \ \ \ \ \ \ source\ \"file:///Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/remote2\"'
       '\ \ \ \ \ \ end'
       ''
       '\ \ \ \ \ \ require\ \"fileutils\"'
       '
       Resolving dependencies...
       The Gemfile specifies no dependencies
       /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/set-1.0.2/lib/set.rb:855: warning: method redefined; discarding old to_set
       <internal:prelude>:28: warning: previous definition of to_set was here
       # $? => 0

       expected: "The Gemfile specifies no dependencies"
            got: "The Gemfile specifies no dependencies\n/Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/syste...ined; discarding old to_set\n<internal:prelude>:28: warning: previous definition of to_set was here"

       (compared using ==)

       Diff:
       @@ -1,3 +1,5 @@
        The Gemfile specifies no dependencies
       +/Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/set-1.0.2/lib/set.rb:855: warning: method redefined; discarding old to_set
       +<internal:prelude>:28: warning: previous definition of to_set was here

I'm pretty sure it will get fixed once there's a release of set including https://github.com/ruby/set/commit/b5dc8845d5f3236a26604cc8edc957820ab79a80, so I wanted to ask whether there are any plans for a release.

Thanks!

hsbt commented 2 years ago

@deivid-rodriguez I'll handle this 💪

deivid-rodriguez commented 2 years ago

Thank you!! 💪

hsbt commented 2 years ago

@deivid-rodriguez In my understanding, your issue may be fixed by bumping version to 1.0.3.dev without gem release?

hsbt commented 2 years ago

I bumped 1.0.3.dev at https://github.com/ruby/set/commit/40dda15d7fcb93acc31d70ac3a3d56424adf9777 and https://github.com/ruby/ruby/commit/113581d288496f8f3e60851b76b751c081c87213

deivid-rodriguez commented 2 years ago

I don't think so, because those tests currently rely on fetching released versions from rubygems.org and putting them on a pristine GEM_HOME location.

hsbt commented 2 years ago

okay, I'll release 1.0.3 tomorrow.

hsbt commented 2 years ago

done https://github.com/ruby/set/releases/tag/v1.0.3

deivid-rodriguez commented 2 years ago

Thank you, hopefully it works!