search

ruby / setup-ruby-pkgs

Cross platform action for Ruby CI
MIT License
13 stars 6 forks source link

Install target mingw packages, no partial upgrade #38

Closed deivid-rodriguez closed 9 months ago

deivid-rodriguez commented 9 months ago

A package change in https://github.com/msys2/MINGW-packages/pull/19913 made this pacman command to start failing.

See for example https://github.com/rubygems/rubygems/actions/runs/7755580051/job/21151329683?pr=7422.

Upstream they recommended to run either -S (no upgrade) or -Syu (full upgrade).

I went with the former because it seems like a more deterministic thing to do.

MSP-Greg commented 9 months ago

Thanks. Let me look into this...

deivid-rodriguez commented 9 months ago

I probably messed something up when packaging in dist?

MSP-Greg commented 9 months ago

@deivid-rodriguez

I probably messed something up when packaging in dist?

No, that isn't the issue. This is something that happened once before.

Can you check this now?

If a repo has no commits, GitHub Actions cron jobs stop running after some time interval that cannot be changed.

The MSYS2 archive files are created by https://github.com/ruby/setup-msys2-gcc, and the CI there stopped. I just reenabled them, and ran the CI.

I'm going to set more frequent reminders to check that, or maybe make a commit once every two weeks...

deivid-rodriguez commented 9 months ago

Can you check this now?

What do I need to do? Force-push?

MSP-Greg commented 9 months ago

@deivid-rodriguez

Sorry, nothing to do here. I'm checking whether this is fixed. CI Is running right now, added clang to a Puma run in my fork. It also uses this repo's action.

CI passed (installed clang), so your RubyGems workflows should be passing now. Also, no need for this PR.

MSP-Greg commented 9 months ago

See https://github.com/MSP-Greg/puma/actions/runs/7758399762/job/21160121413#step:5:81

That job installed clang...

deivid-rodriguez commented 9 months ago

Things were broken for us an hour ago, that's why I started troubleshooting this. Glad it's all good now.

deivid-rodriguez commented 9 months ago

It does seem better to me regardless to not upgrade anything under the hood unless not explicitly requested, even more knowing that this has indeed broken at some point and that https://github.com/msys2/MINGW-packages/ maintainers stated -Sy as "not supported" and likely to break with package renames like it happened here.

But this is totally up to you!