ruby / setup-ruby

An action to download a prebuilt Ruby and add it to the PATH in 5 seconds
https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
MIT License
788 stars 255 forks source link

head version for windows platform is uncompleted build #570

Closed hsbt closed 7 months ago

hsbt commented 7 months ago

Ensure the following before filing this issue

Are you running on a GitHub-hosted runner or a self-hosted runner?

GitHub-hosted runner

Link to the failed workflow job (must be a public workflow job, so the necessary information is available)

https://github.com/ruby/rake/actions/runs/7780963597/job/21214533251?pr=542#step:5:27

Any other notes?

@MSP-Greg head version for Windows platform like windows-latest is not complete to build bundled gems.

Failure: test_dot_rake_files_can_be_loaded_with_dash_r(TestRakeFunctional): <"Ignoring syslog-0.1.2 because its extensions are not built. Try: gem pristine syslog --version 0.1.2\n"> was expected to be empty.

Above failure shows that syslog didn't build with ruby-head. It may be fixed you add --without-ext=+,syslog option to configure.

MSP-Greg commented 7 months ago

@hsbt

Thanks for the reminder. JFYI, ruby-loco master builds are mingw, ucrt, & mswin. RubyInstaller2 builds the head build.

Ping @larskanis

MSP-Greg commented 7 months ago

@hsbt It seems that --without-ext=+,syslog does not work with bundled gems...

Will need to modify bundled_gems

eregon commented 7 months ago

Could you file the issue at https://github.com/oneclick/rubyinstaller2 instead? There is nothing to change in setup-ruby to fix this.

MSP-Greg commented 7 months ago

@hsbt

Shouldn't syslog be accounted for in Ruby's tooling that works with the gems/bundled_gems file? Or, this is a Ruby issue, not an issue with RubyInstaller2 or ruby-loco?

@eregon Sorry...

hsbt commented 7 months ago

Okay, I leave from this issue. I don't have spare time for 3rd party build.