ruby / setup-ruby

An action to download a prebuilt Ruby and add it to the PATH in 5 seconds
https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
MIT License
788 stars 255 forks source link

Request: Support Windows on Arm64 #600

Closed johnnyshields closed 4 months ago

johnnyshields commented 4 months ago

Ruby recently added support for windows-arm64.

The Ruby Installer team would like to support Windows on Arm64 as well, but the current ticket is blocked due to lack of setup-ruby support for windows-arm

Therefore, I would like to request support. Unfortunately Github is not providing Windows ARM runners out-of-the-box. My company TableCheck would be happy to provide self-hosted Windows ARM runners until Github gives official support if it helps.

MSP-Greg commented 4 months ago

provide self-hosted Windows ARM runners

I know nothing about Windows on Arm64.

Do any current Actions Windows images run on Arm64? setup-ruby requires node.js.

Regardless, I'll have a look at what MSYS2 has available.

eregon commented 4 months ago

Can you use setup-ruby in self-hosted mode then? Just use it and follow the steps it mentions in the error.

I don't think much more support is realistic for a platform without official runners.

johnnyshields commented 4 months ago

Issue for Github runners: https://github.com/actions/runner-images/issues/768

eregon commented 4 months ago

I forgot, Windows is a bit special, setup-ruby uses RubyInstaller, like the README says. https://rubyinstaller.org/downloads/ does not seem to have arm64 builds, so that needs to happen first (feel free to file an issue there). Once that is done I think we could support windows arm64 easily in setup-ruby, whether self hosted or not because those builds should work in either case (EDIT: though the windows toolchain stuff needs to be adapted too, and not sure how well that would work in self hosted).

eregon commented 4 months ago

So that's https://github.com/oneclick/rubyinstaller2/issues/362 and that's blocking this issue.

johnnyshields commented 4 months ago

OK @eregon thank you for the clarification!

eregon commented 4 months ago

Thinking more about this, this issue is blocked by two things:

I thought originally the second point might be less important if we are "just using RubyInstaller2 builds", but that's not the case, the windows toolchain stuff also needs to be done and that should be tested properly. Also in general support setup-ruby does not support any version/platform it cannot test.

So I will close this issue for now, and we can reopen it when both these blockers are resolved.


My company TableCheck would be happy to provide self-hosted Windows ARM runners until Github gives official support if it helps.

This wouldn't work unfortunately, there are several concerns with that: