bundle install should honor BUNDLE_JOBS configuration

ruby / setup-ruby

An action to download a prebuilt Ruby and add it to the PATH in 5 seconds

https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby

MIT License

804 stars 263 forks source link

bundle install should honor BUNDLE_JOBS configuration #673

Open mcartoixa opened 10 hours ago

mcartoixa commented 10 hours ago

We just ran into a bug related to Bundler where transitive dependencies would not resolve correctly when parallel installation (--jobs option) is enabled. The problem with the current action is that there is no way to configure this behaviour as it is hardcoded to 4 (cf. bundler.js).

It would be very helpful if the BUNDLE_JOBS configuration, if present, could be honored.

eregon commented 7 hours ago

PR welcome. I don't recall why we pass --jobs 4, apparently since https://github.com/ruby/setup-ruby/pull/56. Probably it was experimented and found to be the fastest on the GH runners at the time.

eregon commented 7 hours ago

Could link that Bundler issue here BTW?