search

ruby / spec

The Ruby Spec Suite aka ruby/spec
MIT License
595 stars 388 forks source link

Add specs for OpenSSL::KDF.pbkdf2_hmac #1092

Closed herwinw closed 11 months ago

herwinw commented 12 months ago

A lot of error messages depend on the used OpenSSL version, so I had to be a bit lenient with the error matching.

eregon commented 12 months ago

Looks like there is one failure: https://github.com/ruby/spec/actions/runs/6472919326/job/17574520140?pr=1092

herwinw commented 11 months ago

Today I Learned: the value of OpenSSL::VERSION is the version of the gem, and not the version of OpenSSL. The Windows issues have been fixed now.

andrykonchin commented 11 months ago

Could you please squash commits?

herwinw commented 11 months ago

Could you please squash commits?

They're squashed into a single commit.

andrykonchin commented 11 months ago

Thank you!

eregon commented 10 months ago

@herwinw FYI: https://github.com/ruby/spec/commit/92f6df8212b0aafb076c990c0592683b81af83e9