Remove evals from pattern-matching spec

ruby / spec

The Ruby Spec Suite aka ruby/spec

MIT License

595 stars 388 forks source link

Remove evals from pattern-matching spec #1155

Closed headius closed 4 months ago

headius commented 4 months ago

Some evals remain for SyntaxError tests that would not parse in the main script.

Most of this was done using automated tools so a few irrelevant formatting changes may have crept in.

Fixes #1152

headius commented 4 months ago

Rubocop had to be bumped to 3.1 to support the newer pattern syntax. Bumping to 3.3 brought out a bunch of issues with requires like 'fiber' and 'set' that are no longer needed.

eregon commented 4 months ago

Thank you, it looks great.

We could have kept the 3.1 stuff in eval's (would address RuboCop and not need a separate file), but anyway I guess we'll make ruby/spec 3.1+ soon since 3.0 is EOL now. At that point we can also put language/pattern_matching/3.1.rb back in language/pattern_matching_spec.rb.