search

ruby / spec

The Ruby Spec Suite aka ruby/spec
MIT License
600 stars 388 forks source link

Update shared specs for Process.fork/Kernel.fork/Kernel#fork #1214

Closed herwinw closed 1 week ago

herwinw commented 2 weeks ago

A number of tests called Process.fork, so the specs for Kernel were mostly calling the wrong method.

andrykonchin commented 1 week ago

The GitHub merge option "Create a merge commit" is disabled. What is a proper way to merge PR now? cc @eregon

eregon commented 1 week ago

Rebase and merge is better

eregon commented 1 week ago

In general I'm trying to keep the ruby/spec history linear as it makes it much simpler e.g. to understand what changes happened to a file, in which order, without having to consider conflicts. When we sync we rebase anyway.