search

ruby / spec

The Ruby Spec Suite aka ruby/spec
MIT License
600 stars 389 forks source link

Flakey test exceeds timeout on CI / specs (macos, 2.7.1) #775

Open sambostock opened 4 years ago

sambostock commented 4 years ago

There is a test which occasionally exceeds the 30 second timeout on CI / specs (macos, 2.7.1), causing the test suite to fail, even if the changes being tested haven't broken anything.

The following logs are from this run

$ ruby /Users/runner/runners/2.263.0/work/spec/mspec/bin/mspec-run --timeout 30
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19]

CVE-2020-10663 is resisted by only creating custom objects if passed create_additions: true or using JSON.load
Example took longer than the configured timeout of 30.0s
eregon commented 4 years ago

This is surprising because for me this spec runs in like 5ms.

I'd like to see another instance before bumping the timeout higher.