Cleanup proc_spec.rb and block_spec.rb

ruby / spec

The Ruby Spec Suite aka ruby/spec

MIT License

596 stars 388 forks source link

Cleanup proc_spec.rb and block_spec.rb #971

Open eregon opened 2 years ago

eregon commented 2 years ago

Currently it's a mess with lambda in proc_spec.rb.

Proposed organization:

block_spec.rb: only passing a block to something else
lambda_spec.rb: as it is, lambda semantics
proc_spec.rb: remove lambda in it, and move most of block_spec.rb, so it's about Proc semantics.

eregon commented 2 years ago

On further thought, I think we should not have block_spec.rb, it's too confusing. Let's move the block-passing specs to method_spec.rb. And lambda_spec.rb is mostly redundant with method_spec.rb in terms of argument handling, so I don't mind if lambda isn't tested in many cases, it's the same anyway.

So then we have a clear proc_spec.rb vs lambda_spec.rb separation, and no "block" to confuse us.