ruby / stringio

Pseudo `IO` class from/to `String`.
BSD 2-Clause "Simplified" License
36 stars 26 forks source link

Add arity-checking anywhere it is missing #48

Closed headius closed 1 year ago

headius commented 1 year ago

As part of jruby/jruby#7751 we are recommending that all extension code manually check the arity of incoming arguments to variable- arity methods, as in CRuby. This ensures that all call paths will be checked, including direct paths from Java or invokedynamic, and avoids array indexing errors in these situations.

headius commented 1 year ago

@hsbt @jeremyevans @mrkn If we can get this in a small release that would be great. Let me know if you can do it or if I should.

jeremyevans commented 1 year ago

I've never done a stringio release. We should probably ask @nobu, since he is the maintainer and did the last release.

kou commented 1 year ago

I can do it.

kou commented 1 year ago

@headius Released!