Implement StringIO#pread

ruby / stringio

Pseudo `IO` class from/to `String`.

BSD 2-Clause "Simplified" License

36 stars 26 forks source link

Closed casperisfine closed 1 year ago

casperisfine commented 1 year ago

Both for being closer to real IOs and also because it's a convenient API in multithreaded scenarios.

cc @kddnewton @nobu

casperisfine commented 1 year ago

@kou I applied your suggestions.

casperisfine commented 1 year ago

@kou done.

We need a review for JRuby part

No problem. Note that there are pre-existing failures on the JRuby suite, but the added test does pass on JRuby.

kou commented 1 year ago

OK. I've merged this.