search

ruby / stringio

Pseudo `IO` class from/to `String`.
BSD 2-Clause "Simplified" License
33 stars 26 forks source link

Remove special handling of chilled strings #96

Closed casperisfine closed 3 months ago

casperisfine commented 3 months ago

[Feature #20205]

Followup: https://github.com/ruby/stringio/pull/94

They no longer need to be special cases. If StringIO end up mutating a chilled string, a warning will be emitted.

eregon commented 3 months ago

This looks like a clear cleanup so I'll merge (I think no need for more reviews before). cc @nobu since you reviewed the related PR.

kou commented 3 months ago

Could you also remove #include <stdbool.h> added by https://github.com/ruby/stringio/pull/94/files#diff-409e35b5049888d5d4b3f2fb8ddb3322e27e1dd47b1e7b7e8b6f52b696f287b7R18 ?