search

ruby / tempfile

A utility class for managing temporary files.
Other
29 stars 10 forks source link

CI: macos-13 for Ruby 2.5 #32

Closed olleolleolle closed 2 weeks ago

olleolleolle commented 3 weeks ago

This uses now-compatible "os" choices for Ruby ~2.4~, 2.5.

This failed in the build of #31.

I enabled fail-fast: false to be able to iterate on the CI workflow.

Found this: ``` Bundler found conflicting requirements for the Ruby version: In Gemfile: tempfile was resolved to 0.2.1, which depends on Ruby (>= 2.5.0) Current Ruby version: Ruby (= 2.4.10) ``` EDIT: Noted that I had wrongly added 2.4 I am removing the 2.4 from the workflow.

Also: There are errors about a Tempfile lacking a filename in the failed tests. (These are for Ruby versions 3.1 and below.)

olleolleolle commented 3 weeks ago

Did the "anonymous: true" change fail for these (< Ruby 3.2) versions? https://github.com/ruby/tempfile/commit/57e9af454060bc012d12417e55a7396a5aef8968

olleolleolle commented 3 weeks ago

I suggest we merge this PR, to have better visibility on master about what CI results we have.

hsbt commented 2 weeks ago

@olleolleolle Thanks for rising this. I added workaround for that at https://github.com/ruby/tempfile/pull/35

olleolleolle commented 2 weeks ago

@hsbt Perfect fix!