Don't move the timer_thread when it's enclosed #24

ruby / timeout

Timeout provides a way to auto-terminate a potentially long-running operation if it hasn't finished in a fixed amount of time.

Other

143 stars 21 forks source link

Don't move the timer_thread when it's enclosed #24 #25

Closed gamecreature closed 1 year ago

gamecreature commented 1 year ago

Don't move the timer_thread to ThreadGroup::Default, when it's created in an enclosed ThreadGroup. Prevents the exception: "add" can't move from the enclosed thread group" Fixes #24.

gamecreature commented 1 year ago

Much better with this simplification!

eregon commented 1 year ago

@hsbt Hello, could you make a release of timeout with this change? I could also do it myself if you give me permission and tell me how to release it + push the gem, up to you. Regarding the version, 0.3.2 seems fine, this is a bug fix.

hsbt commented 1 year ago

@eregon done! https://github.com/ruby/timeout/releases/tag/v0.3.2