JRuby support - Githubissues

ruby / tmpdir

Retrieve temporary directory path

5 stars 11 forks source link

Open headius opened 2 years ago

headius commented 2 years ago

JRuby has a few minor modifications to tmpdir that we should evaluate to merge or remove. Most of these are pretty simple changes.

I will do the work to get these changes incorporated into the gem.

hsbt commented 2 years ago

I'm okay to merge JRuby's tmpdir changes if you want to keep it.

headius commented 1 year ago

So there are really only two changes:

Switch the etc.so require to etc
Deal with incompatibility in the change @nobu made in 2012: https://github.com/ruby/tmpdir/commit/82068d2c1cea9067268b2f570203ae0147f23fb0

This second item will require fixes in JRuby, or reverting that line just for JRuby temporarily.

headius commented 1 year ago

See also https://github.com/jruby/jruby/issues/3698 which describes the problem with using join instead of expand_path on JRuby.