search

ruby / uri

URI is a module providing classes to handle Uniform Resource Identifiers
https://ruby.github.io/uri/
Other
85 stars 46 forks source link

URI::PATTERN NameError starting with version 1.0.0 #125

Closed jrafanie closed 2 weeks ago

jrafanie commented 2 weeks ago

Thanks in advance for your work on this library.

URI::PATTERN constant has existed for a long time, since at least ruby 2.1/ URI 0.9.11. It looks like URI 1.0.0 dropped it without deprecating it. Was this intentional?

% ruby -e "puts RUBY_VERSION; require 'uri'; puts URI::VERSION; puts URI::PATTERN"
3.3.5
0.13.1
URI::RFC2396_REGEXP::PATTERN
% ruby -e "puts RUBY_VERSION; require 'uri'; puts URI::VERSION; puts URI::PATTERN"
3.3.5
1.0.0
/Users/joerafaniello/.gem/ruby/3.3.5/gems/uri-1.0.0/lib/uri/common.rb:53:in `const_missing': uninitialized constant URI::PATTERN (NameError)
    from -e:1:in `<main>'

Running all-ruby, we can see it's been there a long time. If we can't use it, please deprecate it and suggest a replacement. Thanks!

% podman run --rm -e "ALL_RUBY_SHOW_DUP=yes" -e "ALL_RUBY_SINCE=ruby-2.1" -e "ALL_RUBY_ADDBINS=/usr/bin/ruby" rubylang/all-ruby ./all-ruby -e 'require "uri"; puts "version: #{URI::VERSION} pattern: #{URI::PATTERN}"'
WARNING: image platform (linux/amd64) does not match the expected platform (linux/arm64)
ruby-2.1.0          version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.1          version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.2          version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.3          version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.4          version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.5          version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.6          version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.7          version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.8          version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.9          version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.1.10         version: 0.9.11 pattern: URI::REGEXP::PATTERN
ruby-2.2.0-preview1 version: 0.9.11 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.0-rc1      version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.0          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.1          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.2          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.3          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.4          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.5          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.6          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.7          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.8          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.9          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.2.10         version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.0          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.1          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.2          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.3          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.4          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.5          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.6          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.7          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.3.8          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.0-preview3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.0-rc1      version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.0          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.1          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.2          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.3          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.4          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.5          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.6          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.7          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.9          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.4.10         version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.0-rc1      version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.0          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.1          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.2          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.3          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.4          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.5          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.6          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.7          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.8          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.5.9          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0-preview3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0-rc1      version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0-rc2      version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.0          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.1          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.2          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.3          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.4          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.5          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.6          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.7          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.8          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.9          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.6.10         version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0-preview3 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0-rc1      version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0-rc2      version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.0          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.1          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.2          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.3          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.4          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.5          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.6          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.7          version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-2.7.8          version: 0.10.0.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.0-preview1 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.0-preview2 version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.0-rc1      version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.0          version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.1          version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.2          version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.3          version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.4          version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.5          version: 0.10.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.6          version: 0.10.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.0.7          version: 0.10.3 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.0-preview1 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.0          version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.1          version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.2          version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.3          version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.4          version: 0.12.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.5          version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.1.6          version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.0-preview1 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.0-preview2 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.0-preview3 version: 0.11.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.0-rc1      version: 0.12.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.0          version: 0.12.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.1          version: 0.12.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.2          version: 0.12.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.3          version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.4          version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.5          version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.2.6          version: 0.12.3 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.0-preview1 version: 0.12.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.0-preview2 version: 0.12.2 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.0-preview3 version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.0-rc1      version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.0          version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.1          version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.2          version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.3          version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.4          version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.5          version: 0.13.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.3.6          version: 0.13.1 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.4.0-preview1 version: 0.13.0 pattern: URI::RFC2396_REGEXP::PATTERN
ruby-3.4.0-preview2 /build-all-ruby/3.4.0-preview2/lib/ruby/3.4.0+0/uri/common.rb:53:in 'URI.const_missing': uninitialized constant URI::PATTERN (NameError)
                        from -e:1:in '<main>'
                exit 1
/usr/bin/ruby       version: 0.10.0 pattern: URI::RFC2396_REGEXP::PATTERN
jrafanie commented 2 weeks ago

Looking at the diff from 0.13.1 to 1.0.0, I don't see this warning even with -W2 or --verbose.

https://github.com/ruby/uri/compare/v0.13.1...v1.0.0#diff-936b286152b1184cde04f027289d65e633d0f3ee52fdc42cf4eb072c24312e15R48-R54

  def self.const_missing(const)
    if value = RFC2396_PARSER.regexp[const]
      warn "URI::#{const} is obsolete. Use RFC2396_PARSER.regexp[#{const.inspect}] explicitly.", uplevel: 1 if $VERBOSE
      value
    else
      super
    end
jrafanie commented 2 weeks ago

Please let me know why I'm not receiving the warning and what we should be using instead of URI::PATTERN. Should we be using URI::RFC2396_REGEXP::PATTERN?

jrafanie commented 2 weeks ago

I see that URI::REGEXP was also removed without a deprecation warning.

% ruby -e "puts RUBY_VERSION; require 'uri'; puts URI::VERSION; puts URI::REGEXP"
3.3.5
1.0.0
/Users/joerafaniello/.gem/ruby/3.3.5/gems/uri-1.0.0/lib/uri/common.rb:53:in `const_missing': uninitialized constant URI::REGEXP (NameError)

This worked in many prior rubies.

% podman run --rm -e "ALL_RUBY_SHOW_DUP=yes" -e "ALL_RUBY_SINCE=ruby-2.6" -e "ALL_RUBY_ADDBINS=/usr/bin/ruby" rubylang/all-ruby ./all-ruby -e 'require "uri"; puts "version: #{URI::VERSION} parser: #{URI::REGEXP}"'
WARNING: image platform (linux/amd64) does not match the expected platform (linux/arm64)
ruby-2.6.0          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.6.1          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.6.2          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.6.3          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.6.4          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.6.5          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.6.6          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.6.7          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.6.8          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.6.9          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.6.10         version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.0-preview1 version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.0-preview2 version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.0-preview3 version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.0-rc1      version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.0-rc2      version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.0          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.1          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.2          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.3          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.4          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.5          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.6          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.7          version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-2.7.8          version: 0.10.0.2 parser: URI::RFC2396_REGEXP
ruby-3.0.0-preview1 version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-3.0.0-preview2 version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-3.0.0-rc1      version: 0.10.0 parser: URI::RFC2396_REGEXP
ruby-3.0.0          version: 0.10.1 parser: URI::RFC2396_REGEXP
ruby-3.0.1          version: 0.10.1 parser: URI::RFC2396_REGEXP
ruby-3.0.2          version: 0.10.1 parser: URI::RFC2396_REGEXP
ruby-3.0.3          version: 0.10.1 parser: URI::RFC2396_REGEXP
ruby-3.0.4          version: 0.10.1 parser: URI::RFC2396_REGEXP
ruby-3.0.5          version: 0.10.1 parser: URI::RFC2396_REGEXP
ruby-3.0.6          version: 0.10.2 parser: URI::RFC2396_REGEXP
ruby-3.0.7          version: 0.10.3 parser: URI::RFC2396_REGEXP
ruby-3.1.0-preview1 version: 0.11.0 parser: URI::RFC2396_REGEXP
ruby-3.1.0          version: 0.11.0 parser: URI::RFC2396_REGEXP
ruby-3.1.1          version: 0.11.0 parser: URI::RFC2396_REGEXP
ruby-3.1.2          version: 0.11.0 parser: URI::RFC2396_REGEXP
ruby-3.1.3          version: 0.11.0 parser: URI::RFC2396_REGEXP
ruby-3.1.4          version: 0.12.1 parser: URI::RFC2396_REGEXP
ruby-3.1.5          version: 0.12.2 parser: URI::RFC2396_REGEXP
ruby-3.1.6          version: 0.12.2 parser: URI::RFC2396_REGEXP
ruby-3.2.0-preview1 version: 0.11.0 parser: URI::RFC2396_REGEXP
ruby-3.2.0-preview2 version: 0.11.0 parser: URI::RFC2396_REGEXP
ruby-3.2.0-preview3 version: 0.11.0 parser: URI::RFC2396_REGEXP
ruby-3.2.0-rc1      version: 0.12.0 parser: URI::RFC2396_REGEXP
ruby-3.2.0          version: 0.12.0 parser: URI::RFC2396_REGEXP
ruby-3.2.1          version: 0.12.0 parser: URI::RFC2396_REGEXP
ruby-3.2.2          version: 0.12.1 parser: URI::RFC2396_REGEXP
ruby-3.2.3          version: 0.12.2 parser: URI::RFC2396_REGEXP
ruby-3.2.4          version: 0.12.2 parser: URI::RFC2396_REGEXP
ruby-3.2.5          version: 0.12.2 parser: URI::RFC2396_REGEXP
ruby-3.2.6          version: 0.12.3 parser: URI::RFC2396_REGEXP
ruby-3.3.0-preview1 version: 0.12.1 parser: URI::RFC2396_REGEXP
ruby-3.3.0-preview2 version: 0.12.2 parser: URI::RFC2396_REGEXP
ruby-3.3.0-preview3 version: 0.13.0 parser: URI::RFC2396_REGEXP
ruby-3.3.0-rc1      version: 0.13.0 parser: URI::RFC2396_REGEXP
ruby-3.3.0          version: 0.13.0 parser: URI::RFC2396_REGEXP
ruby-3.3.1          version: 0.13.0 parser: URI::RFC2396_REGEXP
ruby-3.3.2          version: 0.13.0 parser: URI::RFC2396_REGEXP
ruby-3.3.3          version: 0.13.0 parser: URI::RFC2396_REGEXP
ruby-3.3.4          version: 0.13.0 parser: URI::RFC2396_REGEXP
ruby-3.3.5          version: 0.13.1 parser: URI::RFC2396_REGEXP
ruby-3.3.6          version: 0.13.1 parser: URI::RFC2396_REGEXP
ruby-3.4.0-preview1 version: 0.13.0 parser: URI::RFC2396_REGEXP
ruby-3.4.0-preview2 /build-all-ruby/3.4.0-preview2/lib/ruby/3.4.0+0/uri/common.rb:53:in 'URI.const_missing': uninitialized constant URI::REGEXP (NameError)
                    Did you mean?  Regexp
                        from -e:1:in '<main>'
firecall commented 2 weeks ago

Can confirm the above, receiving same:

NameError: uninitialized constant URI::REGEXP (NameError)

hsbt commented 2 weeks ago

Thank you for reporting this.

I fixed at https://github.com/ruby/uri/commit/1f3d3df02a0ff764e9a8a80c8d9e2c1e2d11bdce. And released 1.0.1 with that fix.

jrafanie commented 2 weeks ago

Thank you @hsbt! Using 1.0.1, with warnings enabled, I'm now seeing the warnings for these two constants but it continues to work as it did in earlier versions. Looks good to me. Thank you for the quick response!