Fix to support Ruby 3.0 Ractor

ruby / uri

URI is a module providing classes to handle Uniform Resource Identifiers

https://ruby.github.io/uri/

Other

79 stars 42 forks source link

Fix to support Ruby 3.0 Ractor #22

Closed kvokka closed 3 years ago

kvokka commented 3 years ago

This PR is targeting to solve the same problem as #15 and some ideas are similar, but in contrast this one does not have the problem with multiple constant removal on the start up

https://bugs.ruby-lang.org/issues/17592

eregon commented 3 years ago

IMHO this should be reverted, or improved in a way that:

it does reassign constants
it does not use ObjectSpace.each_object

eregon commented 3 years ago

Yet another possibility, since we are going to break @@schemes['FOO'] = FOO anyway, how about simply limiting URI to the built-in schemes, and if needed provide a way to pass extra schemes e.g., via some Hash argument?

eregon commented 3 years ago

I worked on a clean solution in https://github.com/ruby/uri/pull/26