search

ruby / uri

URI is a module providing classes to handle Uniform Resource Identifiers
https://ruby.github.io/uri/
Other
79 stars 42 forks source link

Add space after `bad URI` #37

Closed jsoref closed 1 month ago

jsoref commented 2 years ago

I'm running dkhamsing/awesome_bot:1.20.0 and it generated things like:

bad URI(is not URI?): "http://nginx.org/en/docs/http/ngx_http_map_module.html#map](http://nginx.org/en/docs/http/ngx_http_map_module.html"

hsbt commented 4 months ago

I'm not sure what is the problem without space. Can you share more details?

setharnold commented 4 months ago

Hey @hsbt, the typical English custom is to put a space before an opening parenthesis and a space after a closing parenthesis. Bad URI (is not URI?) feels much more natural than Bad URI(is not URI?).

There can be some nuance around the right spacing in different situations (see https://english.stackexchange.com/a/6047 for a nice example). In this case I think it'd be easier to read with the space.

Thanks

hsbt commented 1 month ago

I understood. Thanks @setharnold