ruby / xmlrpc

The Ruby standard library package 'xmlrpc'
Other
37 stars 26 forks source link

Integrate xmlrpc-streaming gem #21

Open herwinw opened 5 years ago

herwinw commented 5 years ago

There is a very old gem on https://github.com/washu/xmlrpc-streaming, with the following feature set:

The current release of this Gem is 0.1.0, and it hasn't been updated since 2011. The xmlrpc gem has a parser using libxml nowadays, but these two differ. I have no idea of the gem still works with the current release of xmlrpc.

It would be nice to have the functionality in the addon merged into the base release. I'm open to making the changes, but first I want to be sure this would be accepted, and that merging this foreign gem is even allowed (notify for @washu)

washu commented 5 years ago

you can merge whatever you like, this module was made for a previous job, and i no longer use it myself, so whatever you would like merge is fine by me.

kou commented 5 years ago

I don't take a deeply look at xmlrpc-streaming yet but there is license different. xmlrpc uses the BSD-2-Clause license and xmlrpc-streaming uses the MIT license. If we really merge xmlrpc-streaming, can we change the license of xmlrpc-streaming to the BSD-2-Clause?

herwinw commented 5 years ago

Just to add more confusion: https://github.com/washu/xmlrpc-streaming/blob/master/lib/xmlrpc-streaming.rb has an explicit mention of a license:

Released under the same terms of license as Ruby.