search

ruby / xmlrpc

The Ruby standard library package 'xmlrpc'
Other
37 stars 26 forks source link

Remove hack to prevent years < 1970 in DateTime #7

Closed herwinw closed 7 years ago

herwinw commented 7 years ago

Time can handle dates before epoch perfectly fine. The test here is probably something from ancient times and breaks stuff these days without reason.

herwinw commented 7 years ago

And for the rest of the world: If you ever feel the need to include this kind of workarounds in your code, please add a unit test to see if the other object (outside of your reach) fails when trying to use the invalid range. That way, if the limitation is ever lifted upstream, you don't end up with outdated workarounds.