search

ruby / zlib

Ruby interface for the zlib compression/decompression library
Other
50 stars 35 forks source link

Release new version to include latest patch? #23

Closed jorgemanrubia closed 3 years ago

jorgemanrubia commented 3 years ago

We were hit by this bug that got recently fixed by https://github.com/ruby/zlib/pull/22. Would it be possible to make a new release including it?

I pushed this gem for our case as a temporary measure, but it would be great to be able to use the official one.

By the way, thanks so much to @wanabe for fixing this one 🙏. The possibility of zlib silently writing corrupted data is a serious one and, depending on the scenario, can cause data-loss.

hsbt commented 3 years ago

I'm considering to release it before releasing Ruby 3.0.1.

cjf2xn commented 3 years ago

@hsbt do you know when you can cut a new release that includes #22?

This issue has bitten us quite a few times and it results in data loss as @jorgemanrubia mentioned.

hsbt commented 3 years ago

I cut of 2.1.0 release from https://github.com/ruby/zlib/commit/dd593acaee1bb638e7cf97c6d5684af84055689b