junaruga
commented
12 months ago Reproducer
I created a minimal reproducer below for the test test_deflate_chunked above.
$ cat test/zlib/_test_zlib_test_deflate_chunked.rb
require 'zlib'
z = Zlib::Deflate.new
input = "\x01"
z.deflate(input) do |chunk|
end
final = z.finish
puts "final.length: #{final.length}"x86_64 Fedora 38 (ok)
On my local machine.
$ rpm -qf /lib64/libz.so.1
zlib-1.2.13-3.fc38.x86_64$ ruby -I./lib test/zlib/_test_zlib_test_deflate_chunked.rb
final.length: 9s390x Ubuntu jammy (not ok?)
$ dpkg -S /lib/s390x-linux-gnu/libz.so.1
zlib1g:s390x: /lib/s390x-linux-gnu/libz.so.1
$ dpkg -s zlib1g | grep ^Version
Version: 1:1.2.11.dfsg-2ubuntu9.2$ ruby -I./lib test/zlib/_test_zlib_test_deflate_chunked.rb
final.length: 10Debug
Debug 1
$ gdb --args ruby -I./lib test/zlib/_test_zlib_test_deflate_chunked.rb(gdb) b rb_deflate_deflateOn the x86_64, after executing the do_deflate, the avail_out = 1022, total_out = 2
(gdb) f
#0 rb_deflate_deflate (argc=1, argv=0x7ffff7440060, obj=140737077406920)
at ../../../../ext/zlib/zlib.c:1804
1804 return zstream_detach_buffer(z);
(gdb) p *z
$6 = {flags = 3, buf = 140737077406680, input = 4, mutex = 140737077406880, stream = {
next_in = 0x7fffe7816c19 "", avail_in = 0, total_in = 1, next_out = 0x5654c2 "",
avail_out = 1022, total_out = 2, msg = 0x0, state = 0x4c3880,
zalloc = 0x7ffff7e51771 <zlib_mem_alloc>, zfree = 0x7ffff7e5179e <zlib_mem_free>,
opaque = 0x7fffe7816cc8, data_type = 2, adler = 131074, reserved = 0},
func = 0x7ffff7e5ecf0 <deflate_funcs>}On the s390x, after executing the do_deflate, the values are avail_out = 1021, total_out = 3. These are different.
(gdb) f
#0 rb_deflate_deflate (argc=1, argv=0x3fffceff060, obj=4398000606760)
at ../../../../ext/zlib/zlib.c:1804
1804>- return zstream_detach_buffer(z);
(gdb) p *z
$8 = {flags = 3, buf = 4398000606520, input = 4, mutex = 4398000606720, stream = {
next_in = 0x3fffd438d79 "", avail_in = 0, total_in = 1, next_out = 0x2aa001f4c93 "",-
avail_out = 1021, total_out = 3, msg = 0x0, state = 0x2aa002762a0,-
zalloc = 0x3fffa885b68 <zlib_mem_alloc>, zfree = 0x3fffa885bc8 <zlib_mem_free>,-
opaque = 0x3fffd438e28, data_type = 2, adler = 131074, reserved = 0},-
func = 0x3fffa896d08 <deflate_funcs>}Debug 2
Then I watched when the z->stream.avail_out is changed.
(gdb) b zstream_run_try
(gdb) r
(gdb) watch z->stream.avail_out
(gdb) c
(gdb) c
...x86_64
(gdb) c
Continuing.
Hardware watchpoint 3: z->stream.avail_out
Old value = 1024
New value = 1022
flush_pending (strm=strm@entry=0x6cf850) at /usr/src/debug/zlib-1.2.13-3.fc38.x86_64/deflate.c:824
824 s->pending -= len; (gdb) bt
#0 flush_pending (strm=strm@entry=0x6cf850)
at /usr/src/debug/zlib-1.2.13-3.fc38.x86_64/deflate.c:824
#1 0x00007ffff7f9959a in deflate (strm=0x6cf850, flush=0)
at /usr/src/debug/zlib-1.2.13-3.fc38.x86_64/deflate.c:922
#2 0x00007ffff7e525f0 in zstream_run_func (ptr=0x7fffffffc610) at ../../../../ext/zlib/zlib.c:1024
#3 0x00007ffff7aa1684 in rb_nogvl (func=0x7ffff7e52590 <zstream_run_func>, data1=0x7fffffffc610,
ubf=0x7ffff7e5274c <zstream_unblock_func>, data2=0x7fffffffc610, flags=2) at thread.c:1552
#4 0x00007ffff7e52890 in zstream_run_try (value_arg=140737488340496)
at ../../../../ext/zlib/zlib.c:1115
...(gdb) f
#0 flush_pending (strm=strm@entry=0x6cf850)
at /usr/src/debug/zlib-1.2.13-3.fc38.x86_64/deflate.c:824
824 s->pending -= len;(gdb) l
819 zmemcpy(strm->next_out, s->pending_out, len);
820 strm->next_out += len;
821 s->pending_out += len;
822 strm->total_out += len;
823 strm->avail_out -= len;
824 s->pending -= len;
825 if (s->pending == 0) {
826 s->pending_out = s->pending_buf;
827 }
828 }(gdb) c
Continuing.
Watchpoint 3 deleted because the program has left the block in
which its expression is valid.
0x00007ffff78ff3f1 in rb_ensure (b_proc=0x7ffff7e5276a <zstream_run_try>, data1=140737488340496,
e_proc=0x7ffff7e52a37 <zstream_run_ensure>, data2=140737488340496) at eval.c:1009
1009 result = (*b_proc) (data1);s390x
(gdb) c
Continuing.
Hardware watchpoint 2: z->stream.avail_out
Old value = 0
New value = 1024
zstream_expand_buffer_into (z=0x2aa00272e20, size=1024) at ../../../../ext/zlib/zlib.c:714
714 rb_obj_hide(z->buf);
(gdb) c
Continuing.
Hardware watchpoint 2: z->stream.avail_out
Old value = 1024
New value = 1022
0x000003fffd60930e in ?? () from /lib/s390x-linux-gnu/libz.so.1
(gdb) c
Continuing.
Hardware watchpoint 2: z->stream.avail_out
Old value = 1022
New value = 1021
0x000003fffd60b7da in deflate () from /lib/s390x-linux-gnu/libz.so.1(gdb) bt
#0 0x000003fffd60b7da in deflate () from /lib/s390x-linux-gnu/libz.so.1
#1 0x000003fffa88712e in zstream_run_func (ptr=0x3ffffffd7a0) at ../../../../ext/zlib/zlib.c:1024
#2 0x000003fffdc38202 in rb_nogvl (func=0x3fffa8870b0 <zstream_run_func>, data1=0x3ffffffd7a0,
ubf=0x3fffa887320 <zstream_unblock_func>, data2=0x3ffffffd7a0, flags=2) at thread.c:1552
#3 0x000003fffa8874e4 in zstream_run_try (value_arg=4398046500768)
at ../../../../ext/zlib/zlib.c:1115
#4 0x000003fffda2066c in rb_ensure (b_proc=0x3fffa887368 <zstream_run_try>, data1=4398046500768,
e_proc=0x3fffa887738 <zstream_run_ensure>, data2=4398046500768) at eval.c:1009
...(gdb) f
#0 0x000003fffd60b7da in deflate () from /lib/s390x-linux-gnu/libz.so.1
(gdb) l
709 /* I uses rb_str_new here not rb_str_buf_new because
710 rb_str_buf_new makes a zero-length string. */
711 z->buf = rb_str_buf_new(size);
712 z->stream.next_out = (Bytef*)RSTRING_PTR(z->buf);
713 z->stream.avail_out = MAX_UINT(size);
714 rb_obj_hide(z->buf);
715 }
716 else if (z->stream.avail_out != size) {
717 rb_str_modify_expand(z->buf, size);
718 z->stream.next_out = (Bytef*)RSTRING_END(z->buf);Now I want to install a debug symbol of the zlib package to print the lines in the zlib library in Ubuntu jammy. Do you know how to do it?
iii-i
I am seeing the following test failures on RubyCI Ubuntu s390x version Jammy (22.04.3 LTS) on the ruby/zlib latest master branch 85637fa0fc2e5f9f1b9d8fd6652f9d81fd37f4d1 with the latest ruby/ruby master branch. Could you take a look at the failures? I think you can log in to the RubyCI Ubuntu s390x server to debug. Thank you for your help.
Below is the used Zlib deb package version.
ruby/ruby
I also can see the failures in ruby/ruby latest master branch
05a853c2f21f60f9e1c544c2d0709f10de453571.