rubyamf / rocketamf

52 stars 34 forks source link

A few updates for your review #2

Closed shreeve closed 5 years ago

shreeve commented 13 years ago

warhammerkid,

Thanks for your recent updates to RocketAMF. I made a few additional tweaks to enable my BlazeDS wrapper to work "out of the box" with your latest version. The commit message is:

* add HTTPMessage, SOAPMessage, and allow reserved attribute names with trailing underscore

The trailing underscore approach is probably lame, but there are some of the BlazeDS messages that use "method" as an attribute name. Since that conflicts with the existing usage of a method with the name "method", I just appended an underscore and then deal with it specifically (which is kind of ugly). Is there a cleaner way to handle this?

Thanks,

Steve