rubyatscale / danger-packwerk

Danger plugin for packwerk
MIT License
22 stars 5 forks source link

Do not post in deprecated references.yml file when a file is only being renamed #21

Closed alexevanczuk closed 2 years ago

alexevanczuk commented 2 years ago

Renamed files produce false signal because it's not conceptually a "new" violation and creates noise for the user moving code.

Note there are some cases this does not cover. Namely -- this covers not posting a comment when a file that is doing referencing is renamed. However, it will still post a comment on renamed constants. If we wanted to ignore renamed constants, we'd need to find renamed files and use zeitwerk to find the fully qualified constant for the renamed files and ALSO ignore added violations related to that renamed constant.