This is the first of two PRs to clean up the test suite.
This PR does the following:
1) It takes common test setup that is an implementation detail (and thus distracts from the behavior of the test) into a common helper
2) It cleans up some let blocks
3) It removes an unnecessary, redundant context
4) It adds some test cases for edge cases that are not covered whose behavior might change when I open a PR for https://github.com/BigRails/danger-packwerk/issues/2
The next PR will:
1) Improve it block descriptions to be more clear about what the expected outcome is
2) It will create a custom matcher have_inline_markdown that encapsulates some common test details, such as:
It ensures there are no other types of danger messages besides markdown
It identifies what line number the comment is on so its simpler to visualize the danger message
Summary
This is the first of two PRs to clean up the test suite.
This PR does the following: 1) It takes common test setup that is an implementation detail (and thus distracts from the behavior of the test) into a common helper 2) It cleans up some let blocks 3) It removes an unnecessary, redundant context 4) It adds some test cases for edge cases that are not covered whose behavior might change when I open a PR for https://github.com/BigRails/danger-packwerk/issues/2
The next PR will: 1) Improve
itblock descriptions to be more clear about what the expected outcome is 2) It will create a custom matcherhave_inline_markdownthat encapsulates some common test details, such as:markdownCommits