search

rubyatscale / danger-packwerk

Danger plugin for packwerk
MIT License
22 stars 5 forks source link

Danger check for `packwerk validate` (acyclic dependencies) #9

Open alexevanczuk opened 2 years ago

alexevanczuk commented 2 years ago

It could be interesting to include a danger check when bin/packwerk validate fails due to cyclic dependencies.

This is a great entry point to start a conversation about what the ideal dependency order should be, so being notified about this and using it as an educational moment could be helpful.

Gusto does not have this check internally today. If there is interest, this could be a cool check to add.

Note this might require some changes upstream to permit validate to return a structured response, but I haven't yet investigated whether the validate command can already return structured objects when using the ruby (i.e. not CLI) API.

schoblaska commented 8 months ago

This seems like potentially a good idea! Leaving this issue open for now to track, though it is probably low priority for us.