search

rubyberlin / code-of-conduct

http://rubyberlin.github.io/code-of-conduct/
83 stars 182 forks source link

Refresh Polish translation #161

Closed fdmarcin closed 6 years ago

fdmarcin commented 6 years ago

Also, updated CC licence link.

Xylakant commented 6 years ago

ping @pestkownica

fdmarcin commented 6 years ago

Done, @hagenburger. I'm leaving the translation here.

chastell commented 6 years ago

Thanks so much, @fdmarcin! The wording changes are great (I’m not sure about the extra commas, but they don’t bother me either). I’m only surprised by the extra link added in place of a paragraph break.

chastell commented 6 years ago

@fdmarcin Looks good, thanks!

@hagenburger Should I merge this or would you like to wait for another review first?

hagenburger commented 6 years ago

@chastell thanks for your feedback!

@1000miles @lauralindal @skade you recently discussed about processes when I wasn’t there. Did you set any rules on language reviews?

(Side node for all: The merge should use “Squash and merge”)

chastell commented 6 years ago

@hagenburger @1000miles @lauralindal @skade Argh, right, this is probably not the place to discuss this, but if there are clear rules what is mergeable by people like me (and when) I’d appreciate it a lot. ♥

(I merged #154 on a whim yesterday but maybe I shouldn’t have? I’m also not sure who has the power to (re)deploy the site; given that PR is not reflected in production I assume it’s not done automatically.)

fdmarcin commented 6 years ago

Hi, has anything changed?

fdmarcin commented 6 years ago

Hi, should anything be done with this, or can it be merged? cc @hagenburger @chastell

hagenburger commented 6 years ago

@fdmarcin if @chastell is fine with it, we can merge. Could you maybe rebase to master and solve the merge conflicts?

fdmarcin commented 6 years ago

@hagenburger Is it okay now? I haven't done this before across forks instead of branches.

hagenburger commented 6 years ago

I merged that into master manually. Thank you!