search

rubyberlin / code-of-conduct

http://rubyberlin.github.io/code-of-conduct/
83 stars 185 forks source link

Correct PDX CoC links #215

Closed shushugah closed 5 years ago

shushugah commented 5 years ago

Similar to pull request #209 with the commit sha of 27c90f. I also updated russian specifically to say "Portland Code of Conduct", because it's the one language where PDX is most confusing.

Using the gem html-proofer I checked if any other links were broken, excluding twitter/meetup and 301/0 exit status links. All looks good otherwise. If you want to investigate further, here was my script

task :htmlproof do
  require "html-proofer"
  options = {
    :typhoeus => {
    :ssl_verifypeer => false,
    :ssl_verifyhost => 0
    },
    :url_ignore => [/twitter.com/, /meetup.com/],
    :http_status_ignore => [0, 301, 302]
  }
  HTMLProofer.check_directory("build", options).run
end
shushugah commented 5 years ago

The HTMLProofer is not reliable/satisfactory given the number of links enclosed, so I tried to reduce the number of calls it made by excluding social media handles. It's not our fault, if a person deletes/renames their handle. When a new event is added, that's the appropriate time to check their social media contact info.

shushugah commented 5 years ago

Thank you @sapegin, the Russian text was committed. This PR is ready to be merged.

hagenburger commented 5 years ago

Thank you, @shushugah and @sapegin!