rubycas / rubycas-client

Ruby client for Yale's Central Authentication Service protocol -- an open source enterprise single sign on system for web applications.
http://code.google.com/p/rubycas-client/
Other
332 stars 217 forks source link

Wrong variable names at AbstractTicketStore, get_session_for_service_ticket method #30

Closed Buguito closed 12 years ago

Buguito commented 12 years ago

You're receiving "st" as parameter, and using "si" in the read_service_session_lookup(si) call, and also at the logger. This crashes obviously.

Happened to me while attempting to use the single sign out. Without this fixed, i don't know how anyone could make that feature work.

def get_session_for_service_ticket(st) session_id = read_service_session_lookup(si) if session_id session = ActiveRecord::SessionStore::Session.find_by_session_id(session_id) else log.warn("Couldn't destroy session with SessionIndex #{si} because no corresponding session id could be looked up.") end [session_id, session] end

I'm using the gem 2.3.8 btw.

Best regards, Alan //