search

rubycas / rubycas-server

Provides single sign-on authentication for web applications, implementing the server-end of Jasig's CAS protocol.
http://rubycas.github.com
Other
628 stars 270 forks source link

Register user #229

Closed annalisa2014 closed 9 years ago

korun commented 9 years ago

This is odd. O_o

mitfik commented 9 years ago

Hi, thanks a lot for your contribution but I am afraid that we can not take this pull request into consideration due to:

1) Mess in the code (comments, files which should not be there see comments from @korun ) 2) Lack of explanation why you want to do it and which is much more important what you want to achieve 3) The changes (especial for the master branch) should be as small as possible to make the review much easier and make sure that we will avoid bugs. Please consider to split those changes in few PR, if you think that it is worth to have. For example the main change is related with "user registration" by you are modifying the sql authenticator which does not make sens for me.

I am closing this PR since is not possible to accept it in that form. Please do the changes and then reopen it or create new one.

Thanks again for the interest and don't take me wrong but we have to care about the quality of code which we work with. Best regards

korun commented 9 years ago

Maybe it's just a miss click, and the PR was addressed to Navionics:master, it's seems so. =)